diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0115879d5e453d2e77578b3a7b4c8455004815b4..4a5e1741f3cf6f4a63ec8f2cf61f5ea831c1e608 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -158,7 +158,7 @@ detector_documentation: - bash bin/build_documentation | tee doc/detector.md #- | # xmllint --format --xpath '//comment/text()' ${DETECTOR_PATH}/athena.xml | sed -re 's/<\/?\w+>//g' | sed 's/^[[:space:]]*#/#/' | tee doc/detector.md - # xmllint --format --xpath '//comment/text()' ${DETECTOR_PATH}/ip6/ip6_defs.xml | sed -re 's/<\/?\w+>//g' | sed 's/^[[:space:]]*#/#/' | tee -a doc/detector.md || true + # xmllint --format --xpath '//comment/text()' ${DETECTOR_PATH}/ip6/definitions.xml | sed -re 's/<\/?\w+>//g' | sed 's/^[[:space:]]*#/#/' | tee -a doc/detector.md || true # for afile in ${DETECTOR_PATH}/compact/*.xml ; do # xmllint --format --xpath '//comment/text()' ${afile} | sed -re 's/<\/?\w+>//g' | sed 's/^[[:space:]]*#/#/' | tee -a doc/detector.md || true # done @@ -199,7 +199,7 @@ overlap_check_tgeo: script: ## disable fibers in ECAL for normal overlap check - sed -i '/ - - + + @@ -84,17 +84,6 @@ - and more... - - Beamline elements - ----------------- - - - - - - - - ## Main magnet @@ -126,70 +115,17 @@ ## Far foward detectors - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + ## Far foward detectors + + + + + ## Far backward detectors + + FB elements diff --git a/bin/generate_prim_file b/bin/generate_prim_file index a0593210bd2e13fd48f68ba165f57bee0e4c18b3..99d299f921057a314101e61072531e05d8dc7932 100755 --- a/bin/generate_prim_file +++ b/bin/generate_prim_file @@ -52,7 +52,7 @@ parser.add_argument('-t', '--tag', type=str,dest='file_tag', help='Output file tag') parser.add_argument('--timeout', type=int, - default=60, + default=300, help='Timeout in seconds') parser.add_argument('passthrough', nargs='*') diff --git a/compact/definitions.xml b/compact/definitions.xml index 449fcab54c508472e93fb964ca90a1d855f16d88..f87cd72ec0056e7d187f19258afb30500a309190 100644 --- a/compact/definitions.xml +++ b/compact/definitions.xml @@ -231,38 +231,78 @@ The unused IDs below are saved for future use. - #### (150-169) Far Forward Detectors + #### (150-169) Far Forward Detectors - Forward Roman Pot ID: 150 - Forward B0 Tracker ID: 151 - Zero Degree Cal. Ecal ID: 160 - Zero Degree Cal. Hcal ID: 161 - TODO: A lot of the repeated ID's below should be pushed into a single detector + TODO: A lot of the repeated ID's below should be pushed into a single detector - + - + - TODO naming consistency - - + + - #### (170-189) Forward Beamline Magnets + #### (170-189) Far Forward Beamline Magnets + + + + + + + + + + - #### (190-199) Backward Beamline Magnets + #### (190-199) Far Backward Beamline Magnets + + - Low-Q2 Tagger 1 Tracker ID: 195 + - Low-Q2 Tagger 1 Calorimeter ID: 196 + - Low-Q2 Tagger 2 Tracker ID: 198 + - Low-Q2 Tagger 2 Calorimeter ID: 199 + + TODO: A lot of the repeated ID's below should be pushed into a single detector + + + + + + + + + + #### (200-219) Far Backward Beamline Magnets + + + + + + + + + + + + + + ## Detector Definition Parameters diff --git a/compact/subsystem_views/calorimeters.xml b/compact/subsystem_views/calorimeters.xml index 824bc12dc467691410b8dc096ab1448ff457c1b2..99cb334b95bc7e881d30f12c55153818826d3337 100644 --- a/compact/subsystem_views/calorimeters.xml +++ b/compact/subsystem_views/calorimeters.xml @@ -33,8 +33,8 @@ The ip6 (or other ip) defines should be included first. These files have only a define tags. - - + + @@ -86,7 +86,7 @@ Beamline elements ----------------- - + ## Main magnet @@ -101,14 +101,6 @@ - - FB elements - ----------- - None (TODO) - - What is FB? - - diff --git a/compact/subsystem_views/dirc_only.xml b/compact/subsystem_views/dirc_only.xml index 89ecc4d25958945eeafc13b7f4422f0bbcccb095..109cd11b5e81c643f9c859f8b73bafd360f8d18a 100644 --- a/compact/subsystem_views/dirc_only.xml +++ b/compact/subsystem_views/dirc_only.xml @@ -33,8 +33,8 @@ The ip6 (or other ip) defines should be included first. These files have only a define tags. - - + + diff --git a/compact/subsystem_views/drich_only.xml b/compact/subsystem_views/drich_only.xml index 7193fa50b50d1cbb70c1482118e88b701de4667a..6136e3de39f780c11c708734e4cb527f5d23d843 100644 --- a/compact/subsystem_views/drich_only.xml +++ b/compact/subsystem_views/drich_only.xml @@ -33,8 +33,8 @@ The ip6 (or other ip) defines should be included first. These files have only a define tags. - - + + @@ -67,7 +67,7 @@ ## dRICh only - + diff --git a/compact/subsystem_views/inner_detector.xml b/compact/subsystem_views/inner_detector.xml index c1d211777f8ae77d16d33e8e67e5edb1711c57da..bc3bd675db68d0784256dd5cca9ea4c60c176b9a 100644 --- a/compact/subsystem_views/inner_detector.xml +++ b/compact/subsystem_views/inner_detector.xml @@ -33,8 +33,8 @@ The ip6 (or other ip) defines should be included first. These files have only a define tags. - - + + @@ -87,7 +87,7 @@ Beamline elements ----------------- - + ## Main magnet @@ -98,7 +98,6 @@ ## Central tracking detectors - @@ -106,81 +105,6 @@ - - ## Central calorimetry - - - - ## Far foward detectors - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - FB elements - ----------- - None (TODO) - - What is FB? - - diff --git a/compact/subsystem_views/ip6.xml b/compact/subsystem_views/ip6.xml index 65477121623c21590f163ab33d61d39c8d098ef5..780b47ea15941fd9d3bf1482ecc58c3368b2d2c5 100644 --- a/compact/subsystem_views/ip6.xml +++ b/compact/subsystem_views/ip6.xml @@ -1,153 +1,102 @@ - - + + + + + + + + + + + + + + # Athena Detector + - https://eicweb.phy.anl.gov/EIC/detectors/athena.git + - https://eicweb.phy.anl.gov/EIC/detectors/ip6.git + + + + + Athena + - - - - - - - - - - Change this to 275/100/41 to change the field setup - - - - - ===================================== - (150-169) Far Forward Detectors - ===================================== - - Forward B0 Tracker ID: 150 - 153 - Forward Roman Pot ID: 155 - 158 - - Zero Degree Cal. Ecal ID: 163 - Zero Degree Cal. Hcal ID: 164 - - - - - - - - - - - - - - - - - - - - - - - - - - - ===================================== - (170-189) Forward Beamline Magnets - ===================================== - - - - ===================================== - (190-199) Backward Beamline Magnets - ===================================== - - + + ## Main Constant Definitions + + The ip6 (or other ip) defines should be included first. + These files have only a define tags. + + + + - - + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + ## Detector Subsystems + + ### IP Subsystems + + The interaction point subsystems are included before the central detector subsystems. + This is becuase the IP subsystems, for exmaple the beampipe, will define paramters + which are subsquently used in the central detector construction -- e.g. the vertex tracker + uses the beampipe OD to help define its placement. + + The IP subsystems include the Far forward and backward regions. The list of subsystem includes: + - Interaction region beampipe + - B0 tracker + - Off-momentum tracker + - Far forward roman pots + - Zero Degree Calorimeter + - Beam line magnets. + - and more... + + + + ## Far foward detectors + + + + + ## Far foward detectors + + + + + ## Far backward detectors + + diff --git a/compact/subsystem_views/pfrich_only.xml b/compact/subsystem_views/pfrich_only.xml index 3fd28f9285e1125c43f10d65dce684c38042c49a..0f4c0e2081791f5d8459e295898218c89336247c 100644 --- a/compact/subsystem_views/pfrich_only.xml +++ b/compact/subsystem_views/pfrich_only.xml @@ -33,8 +33,8 @@ The ip6 (or other ip) defines should be included first. These files have only a define tags. - - + + @@ -65,7 +65,7 @@ ## pfRICH only - + diff --git a/compact/subsystem_views/pid_only.xml b/compact/subsystem_views/pid_only.xml index 44207a0c2328d1f1f2c1030fdeee36a9424dd18b..0d5443ad79b6238ba5f0a0a2ca35b0a3190da955 100644 --- a/compact/subsystem_views/pid_only.xml +++ b/compact/subsystem_views/pid_only.xml @@ -33,8 +33,8 @@ The ip6 (or other ip) defines should be included first. These files have only a define tags. - - + + @@ -86,16 +86,7 @@ Beamline elements ----------------- - - - Main magnet - ----------- - Note: When changing magnet, also select dimensions in definitions.xml. - - - - ## Central tracking detectors - + PID detectors @@ -103,77 +94,6 @@ - - - FF elements - ----------- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - FB elements - ----------- - None (TODO) - - diff --git a/compact/subsystem_views/tof_only.xml b/compact/subsystem_views/tof_only.xml index 4392434c4ad02308f73ef6647a2e69e5c44073b1..dcbdba9dc7f1e4196cc414e341a721f56785f285 100644 --- a/compact/subsystem_views/tof_only.xml +++ b/compact/subsystem_views/tof_only.xml @@ -33,8 +33,8 @@ The ip6 (or other ip) defines should be included first. These files have only a define tags. - - + + @@ -65,7 +65,7 @@ ## TOF only - + diff --git a/compact/subsystem_views/tracking_only.xml b/compact/subsystem_views/tracking_only.xml index f3195231431d0f5fe1758ff3a1c76653c792e93a..5bef5df898cb9d25dd032f28e5f2abf2a818da47 100644 --- a/compact/subsystem_views/tracking_only.xml +++ b/compact/subsystem_views/tracking_only.xml @@ -33,8 +33,8 @@ The ip6 (or other ip) defines should be included first. These files have only a define tags. - - + + @@ -86,14 +86,7 @@ Beamline elements ----------------- - - - - Main magnet - ----------- - Note: When changing magnet, also select dimensions in definitions.xml. - - + Central tracking detectors @@ -102,74 +95,11 @@ + PID detectors ------------- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - FB elements - ----------- - None (TODO) + diff --git a/compact/subsystem_views/vertex_only.xml b/compact/subsystem_views/vertex_only.xml index 8c818e8f2faa302dc24184e47e130d58652a54a5..46f9e46e3a50827e5ebc93948a4ca670c3f07972 100644 --- a/compact/subsystem_views/vertex_only.xml +++ b/compact/subsystem_views/vertex_only.xml @@ -33,8 +33,8 @@ The ip6 (or other ip) defines should be included first. These files have only a define tags. - - + + @@ -82,95 +82,12 @@ - and more... - - Beamline elements - ----------------- - - - - Main magnet - ----------- - Note: When changing magnet, also select dimensions in definitions.xml. - - - Central tracking detectors -------------------------- - - PID detectors - ------------- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - FB elements - ----------- - None (TODO) - - diff --git a/src/BarrelTrackerWithFrame_geo.cpp b/src/BarrelTrackerWithFrame_geo.cpp index 64210bc5a18ba330e17232d20f7bb4fdea771045..ea0420a068bf5024e4d1a4e754fddaa64da52c73 100644 --- a/src/BarrelTrackerWithFrame_geo.cpp +++ b/src/BarrelTrackerWithFrame_geo.cpp @@ -14,9 +14,13 @@ #include "XML/Layering.h" #include "XML/Utilities.h" +#if defined(USE_ACTSDD4HEP) +#include "ActsDD4hep/ActsExtension.hpp" +#include "ActsDD4hep/ConvertMaterial.hpp" +#else #include "Acts/Plugins/DD4hep/ActsExtension.hpp" #include "Acts/Plugins/DD4hep/ConvertDD4hepMaterial.hpp" - +#endif using namespace std; using namespace dd4hep; diff --git a/src/CompositeTracker_geo.cpp b/src/CompositeTracker_geo.cpp index 33ee7407e77c8a866f16dcd75d30b63e2ec57c17..22f98b9152b568b3376c4a3b3701f20dab8b2062 100644 --- a/src/CompositeTracker_geo.cpp +++ b/src/CompositeTracker_geo.cpp @@ -11,7 +11,11 @@ #include "DD4hep/Printout.h" #include "XML/Utilities.h" +#if defined(USE_ACTSDD4HEP) +#include "ActsDD4hep/ActsExtension.hpp" +#else #include "Acts/Plugins/DD4hep/ActsExtension.hpp" +#endif using namespace dd4hep; using namespace dd4hep::detail; diff --git a/src/CylinderTrackerBarrel_geo.cpp b/src/CylinderTrackerBarrel_geo.cpp index 071b7ee6b18409fc3299f66eaebf33d331f06795..b8141eb31050834cc50c96e5900fc1c14c16ce05 100644 --- a/src/CylinderTrackerBarrel_geo.cpp +++ b/src/CylinderTrackerBarrel_geo.cpp @@ -2,11 +2,17 @@ // Specialized generic detector constructor //========================================================================== -#include "Acts/Plugins/DD4hep/ActsExtension.hpp" -#include "Acts/Plugins/DD4hep/ConvertDD4hepMaterial.hpp" #include "DD4hep/DetFactoryHelper.h" #include "DD4hep/Printout.h" +#if defined(USE_ACTSDD4HEP) +#include "ActsDD4hep/ActsExtension.hpp" +#include "ActsDD4hep/ConvertMaterial.hpp" +#else +#include "Acts/Plugins/DD4hep/ActsExtension.hpp" +#include "Acts/Plugins/DD4hep/ConvertDD4hepMaterial.hpp" +#endif + using namespace std; using namespace dd4hep; using namespace dd4hep::detail; diff --git a/src/SimpleDiskDetector_geo.cpp b/src/SimpleDiskDetector_geo.cpp index 7381a06474c49e24b235f8ad5185291afbc093cd..114c58b51de86d56da2e3afca7ff9160b5097238 100644 --- a/src/SimpleDiskDetector_geo.cpp +++ b/src/SimpleDiskDetector_geo.cpp @@ -15,8 +15,14 @@ // //========================================================================== #include "DD4hep/DetFactoryHelper.h" + +#if defined(USE_ACTSDD4HEP) +#include "ActsDD4hep/ActsExtension.hpp" +#include "ActsDD4hep/ConvertMaterial.hpp" +#else #include "Acts/Plugins/DD4hep/ActsExtension.hpp" #include "Acts/Plugins/DD4hep/ConvertDD4hepMaterial.hpp" +#endif using namespace std; using namespace dd4hep; diff --git a/src/TrapEndcapTracker_geo.cpp b/src/TrapEndcapTracker_geo.cpp index 4930bc952158b5aa117da21ca75dee367daad663..01ff4ef07bab4f1b76e4be88a83aa4f0be06948b 100644 --- a/src/TrapEndcapTracker_geo.cpp +++ b/src/TrapEndcapTracker_geo.cpp @@ -15,8 +15,13 @@ #include "XML/Utilities.h" #include "XML/Layering.h" +#if defined(USE_ACTSDD4HEP) +#include "ActsDD4hep/ActsExtension.hpp" +#include "ActsDD4hep/ConvertMaterial.hpp" +#else #include "Acts/Plugins/DD4hep/ActsExtension.hpp" #include "Acts/Plugins/DD4hep/ConvertDD4hepMaterial.hpp" +#endif using namespace std; using namespace dd4hep;