athena merge requestshttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests2021-06-07T21:17:05Zhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/16WIP: HCAL KLM implementation per Belle II design + scint layer in barrel2021-06-07T21:17:05ZWouter DeconinckWIP: HCAL KLM implementation per Belle II design + scint layer in barrelThis implements the Belle II KLM HCAL in endcaps and barrel. In contrast with Belle, it also includes two scintillator layers in the barrel.
Todo:
- [x] simulate some events
- [x] figure out if there's a resolution benchmark already for...This implements the Belle II KLM HCAL in endcaps and barrel. In contrast with Belle, it also includes two scintillator layers in the barrel.
Todo:
- [x] simulate some events
- [x] figure out if there's a resolution benchmark already for the other RPC implementation
- [x] determine if there is a benefit in having the strips implemented in more detail (e.g. add fiber slot, orientations)https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/53adding HadronEndcapHits and ElectronEndcapHits readout2021-06-16T19:54:21ZMiguel Arratiaadding HadronEndcapHits and ElectronEndcapHits readoutupdating hcal to split hadron and electron endcap hit collectionsupdating hcal to split hadron and electron endcap hit collectionshttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/106Draft: Resolve "Grid Pix PID detector"2021-09-21T05:35:56ZDmitry RomanovDraft: Resolve "Grid Pix PID detector"Closes #42Closes #42Dmitry RomanovDmitry Romanovhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/109Draft: Resolve "DIRC better parametrization"2021-07-26T12:13:37ZDmitry RomanovDraft: Resolve "DIRC better parametrization"Closes #54Closes #54Dmitry RomanovDmitry Romanovhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/123Draft: Resolve "Detailed Forward GEM TRD"2022-03-11T15:39:53ZDmitry RomanovDraft: Resolve "Detailed Forward GEM TRD"Closes #59Closes #59Dmitry RomanovDmitry Romanovhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/147Draft: Use Acts with B02021-08-12T17:01:11ZWhitney ArmstrongDraft: Use Acts with B0No idea if this will work.No idea if this will work.https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/157Draft: Debugging acts extension in the vertex barrel.2021-08-12T18:06:37ZWhitney ArmstrongDraft: Debugging acts extension in the vertex barrel.- The vertex barrel has a cylindrical shape now.
modified: src/CylinderTrackerBarrel_geo.cpp- The vertex barrel has a cylindrical shape now.
modified: src/CylinderTrackerBarrel_geo.cpphttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/168Add full overlap check in child pipeline2021-08-16T14:21:15ZWhitney ArmstrongAdd full overlap check in child pipelinenew file: scripts/overlap_pipeline.ymlnew file: scripts/overlap_pipeline.ymlhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/173Resolve "Add Barrel ECAL projection at positive eta"2021-08-18T09:35:32ZMaria ZurekResolve "Add Barrel ECAL projection at positive eta"Closes #81Closes #81Maria ZurekMaria Zurekhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/249Draft: Resolve "Add realistic cooling for Gridpix"2021-09-27T12:09:54ZDmitry RomanovDraft: Resolve "Add realistic cooling for Gridpix"Closes #104Closes #104Dmitry RomanovDmitry Romanovhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/251Acts surface binning2021-10-01T20:23:49ZWhitney ArmstrongActs surface binningFollowing the ODDFollowing the ODDhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/260draft: dualize dRICh mirrors2023-02-09T19:24:13ZChristopher Dilksdraft: dualize dRICh mirrorsclose https://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/117
- the new placement algorithm allows for mirror parameter definitions at the compact file level, e.g.,
```
<mirrors .....>
<mirror backplane="DRICH_window_thickness+1...close https://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/117
- the new placement algorithm allows for mirror parameter definitions at the compact file level, e.g.,
```
<mirrors .....>
<mirror backplane="DRICH_window_thickness+1.0*cm" focus_tune_x="80.0*cm" focus_tune_z="-80.0*cm" />
<mirror backplane="DRICH_window_thickness+1.0*cm" focus_tune_x="60.0*cm" focus_tune_z="0.0*cm" />
</mirrors>
```
- instead of `mirror` parameter set `{backplane,focus_tune_x,focus_tune_z}`, it is trivial to switch to using the set `{radius,centerx,centerz}` to allow one to copy over any fixed mirror parameterizations, in particular those from sandbox G4 optimization results from @ayk1964
- the algorithm is designed to handle 2 mirrors, but should be adaptable enough to handle N mirrors
- the choice of which mirrors to take on which side of the intersection plane is controlled by `splice_mode` (divergent or convergent)Christopher DilksChristopher Dilkshttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/264Calibration files with sampling fractions for ecal/hcals2021-10-13T03:43:48ZWouter DeconinckCalibration files with sampling fractions for ecal/hcalsRetrieving calibrations with curl or from a variety of locations is too fragile. Keep track of them in the geometry.Retrieving calibrations with curl or from a variety of locations is too fragile. Keep track of them in the geometry.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/265Calo digitization json for the active athena geometry2021-10-14T20:22:48ZWouter DeconinckCalo digitization json for the active athena geometry@cpeng This is the same file that's already named 'calo_digi_acadia.json' but with:
- no hardcoded 'acadia' in the name (if the branch is acadia, then this file should have content consistent with acadia but with the default name that do...@cpeng This is the same file that's already named 'calo_digi_acadia.json' but with:
- no hardcoded 'acadia' in the name (if the branch is acadia, then this file should have content consistent with acadia but with the default name that doesn't include the geometry version name),
- the naming scheme for modules as used in reconstruction (e.g. ci_ecal),
- the variable names used by CalHitDigi so we can directly read json and pass to CalHitDigi,
- added energyResolutions so it is a complete set of CalHitDigi options.
I hope we can make this file be the one that is used by reconstruction (I'm working on that next).Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/281Draft: Resolve "Improved GEM rings"2021-10-22T19:01:37ZMerrick LavinskyDraft: Resolve "Improved GEM rings"Closes #126Closes #126canyonlands-v2Merrick LavinskyMerrick Lavinskyhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/286Vizualize DIRC2021-10-27T21:36:20ZSylvester JoostenVizualize DIRCTemp MR for nice rendering with DIRCTemp MR for nice rendering with DIRChttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/299Draft: Resolve "make new 3d views of FF region and detectors"2021-11-05T17:36:46ZAlex JentschDraft: Resolve "make new 3d views of FF region and detectors"Closes #134Closes #134Alex JentschAlex Jentschhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/300Removing hard-coding in backward ecal.2021-11-05T18:36:53ZWhitney ArmstrongRemoving hard-coding in backward ecal.modified: compact/ecal_backward_hybrid.xml
modified: src/HybridCalorimeter_geo.cppmodified: compact/ecal_backward_hybrid.xml
modified: src/HybridCalorimeter_geo.cpphttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/318Set the whole module as sensitive detector and cover insensitive area by daug...2022-02-09T18:52:04ZZhongling JiSet the whole module as sensitive detector and cover insensitive area by daughtersTested giving consistent results in DD4hep and Juggler as the original fiber implementation.Tested giving consistent results in DD4hep and Juggler as the original fiber implementation.Zhongling JiZhongling Jihttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/331Draft: Resolve "add IRT geometry to RICH cpp files"2022-09-03T14:21:45ZChristopher DilksDraft: Resolve "add IRT geometry to RICH cpp files"Closes #144
- Branch cloned and rebased from `irt-init-v01` (to avoid danger of rebasing shared branch)
- requires `irt` moduleCloses #144
- Branch cloned and rebased from `irt-init-v01` (to avoid danger of rebasing shared branch)
- requires `irt` moduleChristopher DilksChristopher Dilks